Skip to content

Add benchmark for exponential histogram measurements #7305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

Add benchmark for exponential histogram measurements #7305

merged 2 commits into from
Sep 8, 2025

Conversation

@dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 4, 2025

This is helpful for my work optimizing locking in #7189

goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/metric
cpu: Intel(R) Xeon(R) CPU @ 2.20GHz
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/0-24         	   43419	       306.0 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/0-24         	   40675	       316.1 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/0-24         	   53746	       305.6 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/0-24         	   38224	       296.1 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/0-24         	   53796	       330.3 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/0-24         	   47823	       316.4 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/1-24         	   32172	       373.5 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/1-24         	   33084	       379.0 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/1-24         	   29956	       360.4 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/1-24         	   33921	       370.1 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/1-24         	   34449	       387.7 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/1-24         	   29156	       393.6 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/10-24        	   10768	      1040 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/10-24        	   11190	      1056 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/10-24        	   11078	      1176 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/10-24        	   10929	      1219 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/10-24        	   10454	      1066 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/NoView/ExponentialFloat64Histogram/Attributes/10-24        	   10501	      1064 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/0-24       	 5919898	         1.879 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/0-24       	 5834685	         1.990 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/0-24       	 5782334	         2.433 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/0-24       	 5320924	         2.404 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/0-24       	 5742800	         2.109 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/0-24       	 5885475	         2.056 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/1-24       	 4331547	         2.758 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/1-24       	 3848244	         2.725 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/1-24       	 4542189	         2.636 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/1-24       	 4201015	         2.641 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/1-24       	 4597094	         2.608 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/1-24       	 4869811	         2.491 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/10-24      	 4826077	         2.329 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/10-24      	 4866612	         2.382 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/10-24      	 5149305	         2.310 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/10-24      	 5101305	         2.384 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/10-24      	 4854940	         2.440 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/DropView/ExponentialFloat64Histogram/Attributes/10-24      	 4874742	         2.501 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/0-24 	   55272	       359.0 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/0-24 	   52195	       318.4 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/0-24 	   52324	       330.8 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/0-24 	   49879	       321.4 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/0-24 	   56212	       351.3 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/0-24 	   43362	       301.4 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/1-24 	   30296	       461.9 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/1-24 	   24178	       469.0 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/1-24 	   24901	       477.0 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/1-24 	   21748	       477.6 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/1-24 	   23972	       512.9 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/1-24 	   28039	       499.5 ns/op	       0 B/op	       0 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/10-24         	    7598	      1646 ns/op	     704 B/op	       2 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/10-24         	    7452	      1660 ns/op	     704 B/op	       2 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/10-24         	    7620	      1644 ns/op	     704 B/op	       2 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/10-24         	    6459	      1853 ns/op	     704 B/op	       2 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/10-24         	    7950	      1575 ns/op	     704 B/op	       2 allocs/op
BenchmarkSyncMeasure/AttrFilterView/ExponentialFloat64Histogram/Attributes/10-24         	    8948	      1421 ns/op	     704 B/op	       2 allocs/op

@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.9%. Comparing base (8ac554a) to head (b991d31).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7305     +/-   ##
=======================================
- Coverage   82.9%   82.9%   -0.1%     
=======================================
  Files        265     265             
  Lines      24898   24898             
=======================================
- Hits       20650   20649      -1     
- Misses      3873    3874      +1     
  Partials     375     375

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit 567ef26 into open-telemetry:main Sep 8, 2025
31 checks passed
@MrAlias MrAlias added this to the v1.39.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes

@flc1125 flc1125 flc1125 approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v1.39.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dashpole @dmathieu @flc1125 @MrAlias